Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): disallow redirects to more script protocols #22366

Merged
merged 17 commits into from Jul 30, 2023
Merged

fix(nuxt): disallow redirects to more script protocols #22366

merged 17 commits into from Jul 30, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This corrects the protocol check to use javascript rather than script.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from manniL July 27, 2023 20:50
@danielroe danielroe self-assigned this Jul 27, 2023
@stackblitz
Copy link

stackblitz bot commented Jul 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe mentioned this pull request Jul 28, 2023
Merged
8 tasks
@danielroe danielroe marked this pull request as draft July 29, 2023 04:34
@danielroe danielroe marked this pull request as ready for review July 29, 2023 07:01
@danielroe danielroe requested a review from pi0 July 29, 2023 07:03
DamianGlowala
DamianGlowala previously requested changes Jul 29, 2023
View reviewed changes
packages/nuxt/src/app/composables/router.ts Outdated Show resolved Hide resolved
packages/nuxt/src/app/composables/router.ts Outdated Show resolved Hide resolved
danielroe and others added 2 commits July 29, 2023 20:02
@danielroe @DamianGlowala
Update packages/nuxt/src/app/composables/router.ts
84e8357 
Co-authored-by: Damian GΕ‚owala <48835293+DamianGlowala@users.noreply.github.com>
@danielroe @DamianGlowala
Update packages/nuxt/src/app/composables/router.ts
9e38249 
Co-authored-by: Damian GΕ‚owala <48835293+DamianGlowala@users.noreply.github.com>
@danielroe danielroe dismissed DamianGlowala’s stale review July 30, 2023 09:05

Implemented βœ…

@danielroe danielroe changed the title fix(nuxt): use correct javascript protocol fix(nuxt): disallow redirects to more script protocols Jul 30, 2023
@danielroe danielroe enabled auto-merge (squash) July 30, 2023 09:45
@danielroe danielroe disabled auto-merge July 30, 2023 10:07
@danielroe danielroe merged commit 2f734df into main Jul 30, 2023
29 checks passed
@danielroe danielroe deleted the danielroe-patch-1 branch July 30, 2023 10:09
@github-actions github-actions bot mentioned this pull request Jul 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manniL manniL manniL approved these changes

@DamianGlowala DamianGlowala DamianGlowala approved these changes

@pi0 pi0 Awaiting requested review from pi0

Assignees

@danielroe danielroe

Labels
3.x bug ❗ p4-important
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danielroe @manniL @pi0 @DamianGlowala