Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): use computed path value for useFetch hash #22378

Merged
merged 1 commit into from Jul 29, 2023
Merged

fix(nuxt): use computed path value for useFetch hash #22378

merged 1 commit into from Jul 29, 2023

Conversation

OhB00
Copy link
Contributor

@OhB00 OhB00 commented Jul 28, 2023 •
edited by danielroe

🔗 Linked issue

resolves #22377.

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Fetch key was not changed when a function was used for the request path. The computed value has been used to calculate the hash key.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jul 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@OhB00 OhB00 changed the title fix(nuxt): Use computed value for hash fix(nuxt): Use computed value for useFetch hash Jul 28, 2023
@OhB00 OhB00 changed the title fix(nuxt): Use computed value for useFetch hash fix(nuxt): Use computed URL value for useFetch hash Jul 28, 2023
@OhB00 OhB00 changed the title fix(nuxt): Use computed URL value for useFetch hash fix(nuxt): Use computed path value for useFetch hash Jul 28, 2023
@danielroe danielroe changed the title fix(nuxt): Use computed path value for useFetch hash fix(nuxt): use computed path value for useFetch hash Jul 29, 2023
@danielroe danielroe merged commit ae8a2fb into nuxt:main Jul 29, 2023
30 of 34 checks passed
@github-actions github-actions bot mentioned this pull request Jul 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useFetch hash collisions when sharing a call
2 participants
@OhB00 @danielroe