Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): support uppercase route methods in useFetch #22418

Merged
merged 4 commits into from Jul 31, 2023
Merged

fix(nuxt): support uppercase route methods in useFetch #22418

merged 4 commits into from Jul 31, 2023

Conversation

ah-dc
Copy link
Contributor

@ah-dc ah-dc commented Jul 31, 2023 •
edited by danielroe

🔗 Linked issue

Resolves #22313

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

tested locally with the reproduction in the issue

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jul 31, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ah-dc ah-dc marked this pull request as draft July 31, 2023 17:47
@ah-dc ah-dc marked this pull request as ready for review July 31, 2023 17:55
@ah-dc
Copy link
Contributor Author

ah-dc commented Jul 31, 2023

maybe this should be done on nitro side

danielroe
danielroe approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@danielroe danielroe merged commit 17461fb into nuxt:main Jul 31, 2023
29 checks passed
@github-actions github-actions bot mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x bug 🔨 p3-minor-bug types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

return type inference does not work with uppercase 'GET' method
2 participants
@ah-dc @danielroe