fix(nuxt): broken capo.js injectHead usage
#22447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
harlan-zw
changed the title
injectHead usageinjectHead usage
danielroe
approved these changes
Aug 2, 2023
danielroe
approved these changes
Aug 2, 2023
|
Some race condition error 🤔 ? |
|
anyway to avoid autofix ci resetting approvals 🙃 |
danielroe
approved these changes
Aug 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
The injectHead doesn't work in SSR Nuxt plugins as the Vue scope isn't available. We also enable the experiment in the basic test fixture so we know it's not breaking any internals.
Sorry, seems like I didn't test this as thoroughly as I thought (forgot to build).
This is also something I'll look to fix in Unhead 2.0.0, attaching a custom context instead of relying on just Vue.
📝 Checklist