chore(schema): enable linting #22546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
danielroe
reviewed
Aug 8, 2023
danielroe
reviewed
Aug 8, 2023
packages/schema/src/types/nuxt.ts
Outdated
Comment on lines
8
to
18
| /** @deprecated use mode */ | ||
| ssr?: boolean | ||
| src: string | ||
| mode?: 'all' | 'server' | 'client' | ||
| /** | ||
| * This allows more granular control over plugin order and should only be used by advanced users. | ||
| * Lower numbers run first, and user plugins default to `0`. | ||
| * | ||
| * Default Nuxt priorities can be seen at [here](https://github.com/nuxt/nuxt/blob/9904849bc87c53dfbd3ea3528140a5684c63c8d8/packages/nuxt/src/core/plugins/plugin-metadata.ts#L15-L34). | ||
| */ | ||
| order?: number |
There was a problem hiding this comment.
Suggested change
| /** @deprecated use mode */ | |
| ssr?: boolean | |
| src: string | |
| mode?: 'all' | 'server' | 'client' | |
| /** | |
| * This allows more granular control over plugin order and should only be used by advanced users. | |
| * Lower numbers run first, and user plugins default to `0`. | |
| * | |
| * Default Nuxt priorities can be seen at [here](https://github.com/nuxt/nuxt/blob/9904849bc87c53dfbd3ea3528140a5684c63c8d8/packages/nuxt/src/core/plugins/plugin-metadata.ts#L15-L34). | |
| */ | |
| order?: number | |
| /** @deprecated use mode */ | |
| ssr?: boolean | |
| src: string | |
| mode?: 'all' | 'server' | 'client' | |
| /** | |
| * This allows more granular control over plugin order and should only be used by advanced users. | |
| * Lower numbers run first, and user plugins default to `0`. | |
| * | |
| * Default Nuxt priorities can be seen at [here](https://github.com/nuxt/nuxt/blob/9904849bc87c53dfbd3ea3528140a5684c63c8d8/packages/nuxt/src/core/plugins/plugin-metadata.ts#L15-L34). | |
| */ | |
| order?: number |
There was a problem hiding this comment.
why do you think this wasn't caught by eslint? 🤔
There was a problem hiding this comment.
Wondering the same, as I tried changing quotes to double quotes, and it correctly detected the issue. Looking at the ssr's indent, for some reason it seems to be fine... (I'll keep digging)
There was a problem hiding this comment.
It appears to have something to do with the folder name types this file is in.
Renaming the folder to anything other than types doesn't seem to make any difference. Odd!
8 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
This PR enables linting for
packages/schemaand applies suggestions, as well as addresses errors resulting from this change.closes #22544
📝 Checklist