Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): remove experimental hash hydration #22648

Merged
merged 1 commit into from Aug 16, 2023

Conversation

harlan-zw
Copy link
Contributor

@harlan-zw harlan-zw commented Aug 15, 2023

πŸ”— Linked issue

Related #22620

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Doing some testing on Nuxt production environments, I believe the HashHydrationPlugin is not ready to be used.

There is an internal issue in Unhead on how non-hydrated dom nodes won't be removed. For users who opt-in and are aware of the constraint it shouldn't be an issue, but for something that we're planning to be enabled by default, I don't think it's worth including it while the issue is present.

Also, it does increase the INP time slightly for page changes so may not be worth it for the performance hit there.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Aug 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe changed the title revert: drop head HashHydrationPlugin fix(nuxt): remove experimental hash hydration Aug 16, 2023
@danielroe danielroe merged commit 28e4cc2 into main Aug 16, 2023
27 checks passed
@danielroe danielroe deleted the fix/remove-head-hash-hydration branch August 16, 2023 08:25
@github-actions github-actions bot mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants