Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): use '' key for root scope in variable collector #22679

Merged
merged 1 commit into from Aug 17, 2023

Conversation

ah-dc
Copy link
Contributor

@ah-dc ah-dc commented Aug 17, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The key of the root scope should be an empty string instead of '0'. I didn't notice this mistake because all setup script code will be put in a nested scope, so I introduced a test case to verify if it can correctly analyze the normal code.

Besides this, I think these code need to be refactored and have independent tests, but currently I don't have good ideas of that.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Aug 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe changed the title fix(vite): fix variable collector uses wrong key for root scope fix(vite): use '' key for root scope in variable collector Aug 17, 2023
@danielroe danielroe merged commit 4e538a0 into nuxt:main Aug 17, 2023
25 checks passed
@github-actions github-actions bot mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants