Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: mention NuxtIsland in server only components docs #22685

Merged
merged 5 commits into from Aug 19, 2023
Merged

docs: mention NuxtIsland in server only components docs #22685

merged 5 commits into from Aug 19, 2023

Conversation

huang-julien
Copy link
Member

@huang-julien huang-julien commented Aug 17, 2023 •
edited

πŸ”— Linked issue

❓ Type of change

Hi πŸ‘‹

this is a small improvement of server components documentation so users understand that server only components are island components

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Aug 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nuxt-studio
Copy link

nuxt-studio bot commented Aug 17, 2023 •
edited by nuxt-studio-dev bot

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nuxt Edit on Studio β†—οΈŽ View Live Preview 9d64da0

@huang-julien @DamianGlowala
Apply suggestions from code review
c6aa2a9 
Co-authored-by: Damian GΕ‚owala <damian.glowala.rebkow@gmail.com>
@huang-julien huang-julien mentioned this pull request Aug 18, 2023
Closed
@huang-julien @danielroe
Update docs/2.guide/2.directory-structure/1.components.md
9d64da0 
Co-authored-by: Daniel Roe <daniel@roe.dev>
@danielroe danielroe merged commit 09971c6 into nuxt:main Aug 19, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Aug 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianGlowala DamianGlowala DamianGlowala requested changes

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huang-julien @danielroe @DamianGlowala