Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vite): only mark nitro deps as externals when building #22812

Merged
merged 2 commits into from Aug 25, 2023
Merged

fix(vite): only mark nitro deps as externals when building #22812

merged 2 commits into from Aug 25, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

#14146

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

When we added nitro deps to externals list, this broke dev mode with vite-node when used without shamefully-hoist.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 August 25, 2023 13:38
@stackblitz
Copy link

stackblitz bot commented Aug 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe merged commit b319087 into main Aug 25, 2023
25 checks passed
@danielroe danielroe deleted the fix/ssr-dev-externals branch August 25, 2023 13:57
@github-actions github-actions bot mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0

Assignees
No one assigned
Labels
3.x bug vite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@danielroe