Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema): export ./schema/config.schema.json subpath #22813

Merged
merged 1 commit into from Aug 25, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 25, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

As talking with @adhamfarrag, this is required subpath to allow external integrations (such as vscode extension) to access current nuxt config schema.

  • It have kept subpath same as real path to reduce chances of resolution mismatches
  • I have only exported this one (with json schema) as also contained defaults. this way we reduce chance of breaking changes by avoid exposing other files.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Aug 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pi0 pi0 requested a review from danielroe August 25, 2023 15:37
@danielroe danielroe changed the title fix(schema): export schema/schema/config.schema.json subpath feat(schema): export ./schema/config.schema.json subpath Aug 25, 2023
@danielroe danielroe merged commit 0094b56 into main Aug 25, 2023
25 checks passed
@danielroe danielroe deleted the fix/schema-exports branch August 25, 2023 16:19
@github-actions github-actions bot mentioned this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants