fix(nuxt): ensure middleware is processed when returning true

[Mini-ghost]

🔗 Linked issue

Resolve #22898

❓ Type of change

• 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

When switching routes, all middleware should run to completion unless there is a middleware redirection or an error occurs. However, currently, if we return true in one of the middleware, the loop will terminate without continuing.

As shown below, when return true is encountered, the loop exits at line 183, even though there are other unexecuted middlewares afterward:

nuxt/packages/nuxt/src/pages/runtime/plugins/router.ts

Lines 182 to 184 in aa0ea8b

	if (result || result === false) {
	return result
	}

Therefore, I added a check in the previous code. If result is true, it allows the loop to continue, executing the next middleware.

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[Mini-ghost]

@danielroe

There are two files in the source code that deal with middleware:

• packages/nuxt/src/pages/runtime/plugins/router.ts
• packages/nuxt/src/app/plugins/router.ts

I'm not certain about the differences between these two files. Should I make changes to both of them?

In packages/nuxt/src/app/plugins/router.ts, it appears that the middleware type differs from Vue Router. I'm unsure if this difference is intentional.

[danielroe]

@Mini-ghost One of them applies when the vue-router integration is not enabled. (Basically when there is no ~/pages directory.) The other one applies when it is.

This is because we have a generally isomorphic integration for routing that can save on bundle size when full-featured routing isn't needed for a site.

[Mini-ghost]

@danielroe

Thank you for your explanation. I have updated the relevant code. I appreciate your help!