fix(nuxt): handle optional params within a path segment #23070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danielroe
reviewed
Sep 8, 2023
test/basic.test.ts
Outdated
| @@ -205,6 +205,42 @@ describe('pages', () => { | |||
| await expectNoClientErrors('/?test=true') | |||
| }) | |||
|
|
|||
| it('/optional/[[opt]].vue', async () => { | |||
There was a problem hiding this comment.
instead, would you update packages/nuxt/test/pages.test.ts? I think we can cover this in a unit test.
There was a problem hiding this comment.
Added unit tests. Do you insist to replace fixtures/basic ones? They also checks the ordering of routes as well.
There was a problem hiding this comment.
Thank you ❤️
I think the route ordering should be tested by vue-router rather than us. The e2e tests here are good but I think we can save the CI time.
danielroe
changed the title
danielroe
approved these changes
Sep 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #23069
❓ Type of change
📚 Description
📝 Checklist