fix(nuxt): exclude data-v attrs from server component props
#23095
Conversation
|
|
huang-julien
changed the title
data-v attributes of cssLoader to NuxtIslanddata-v attributes to NuxtIsland
huang-julien
changed the title
data-v attributes to NuxtIslanddata-v attributes to NuxtIsland
| @@ -7,10 +7,12 @@ export const createServerComponent = (name: string) => { | |||
| inheritAttrs: false, | |||
| props: { lazy: Boolean }, | |||
| setup (props, { attrs, slots }) { | |||
| // #23051 - remove data-v attributes | |||
| const attrsWithoutVueDataAttr = computed(() => Object.entries(attrs).reduce<Record<string, string>>((acc, [key, value]) => key.startsWith('data-v-') ? acc : Object.assign(acc, { [key]: value }), {})) | |||
There was a problem hiding this comment.
I think we should do this within the render function, and I think it would likely be simpler to do Object.fromEntries + Object.entries().filter.
|
Apologies, but if it's fixed by not passing the data-v attribute, won't this break styles during SSG? I think that might be a bigger problem actually, since that means that scoped styles won't apply during SSG and if you want to style server components used inside your components with scoped styles you'll have to use I mean, this can break styles in already existing applications, no? |
huang-julien
changed the title
data-v attributes to NuxtIslanddata-v attributes to NuxtIsland props
|
Oh the title of the PR may not be explicit enough. |
|
Thanks for the clarification! |
danielroe
changed the title
data-v attributes to NuxtIsland propsdata-v attrs from server component props
…s inside rendered component
🔗 Linked issue
fix #23051
❓ Type of change
📚 Description
Hi 👋 this PR resolves #23051 .
I'm not really a fan of having to make a computed + a reduce, but i didn't find another solution atm. Let's admit that server components are not going to be updated every milliseconds 😅 .... If there's a better solution (like a config from vue), let me know.
This only affect
.servercomponents sinceNuxtIslanddirectly usepropsprops attrbute and ignore anydata-vattribute📝 Checklist