Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(nuxt): use built-in consola prompts #23205

Merged
merged 1 commit into from Sep 14, 2023
Merged

refactor(nuxt): use built-in consola prompts #23205

merged 1 commit into from Sep 14, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

nuxt/bridge#907

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Nice catch by @pi0 and @wattanx, we can use built-in consola prompts instead of requiring separate dependency for prompting auto-install of packages.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 September 14, 2023 08:57
@danielroe danielroe self-assigned this Sep 14, 2023
@stackblitz
Copy link

stackblitz bot commented Sep 14, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

pi0
pi0 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@danielroe danielroe merged commit ba3ca72 into main Sep 14, 2023
25 checks passed
@danielroe danielroe deleted the fix/prompts branch September 14, 2023 09:17
@github-actions github-actions bot mentioned this pull request Sep 14, 2023
Merged
@github-actions github-actions bot mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
3.x performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @pi0