refactor(kit,nuxt,schema): use consola and improve test dx
#23302
Conversation
|
|
pi0
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
TLDR: output is more stable yet, Logs are still somehow leaking and spamming CI/Test output. Also, we have random failures with Ubuntu preset (most likely concurrency) but i gues it is worth to iterate over such big refactor into smaller steps... |
| try { | ||
| requests.push(req.url().replace(url('/'), '/')) | ||
| } catch (err) { | ||
| // TODO |
There was a problem hiding this comment.
what kind of error was being triggered here?
There was a problem hiding this comment.
The lovely context is not available one by late calling url()! Turns out we somehow still keep loading the Browser pages after tests are being done and we don't have context anymore.
This was more visible in new nuxi-edge case because we early close server properly now and made it more visible.
However i think would be nice later investigate root causes. Seems we are wasting too much on browser allocation in our tests.
danielroe
changed the title
consola and improve test dx
🔗 Linked issue
Extracted from #23225
❓ Type of change
📚 Description
This PR refactors all packages to leverage consola logger exported from
@nuxt/kit.We use a magical conosla wrapper in CLI that was automatically wrapping all console usages but it can be easily missed when running in tests or with programmatic usage.
Exceptions:
process.clientto avoid clattering outputAdded back a (warning level) eslint rule also for
no-consoleNote: This PR also contains small other eslint tweaks to remove all current warnings.
📝 Checklist