Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): generate empty file when shim is disabled #23333

Merged
merged 1 commit into from Sep 22, 2023
Merged

fix(nuxt): generate empty file when shim is disabled #23333

merged 1 commit into from Sep 22, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #23320

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This generates an empty shim to avoid any issue with it being unintentionally added to project when it's explicitly disabled.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Sep 21, 2023
@stackblitz
Copy link

stackblitz bot commented Sep 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe changed the title fix(nuxt): generate empty shim file when disabled fix(nuxt): generate empty file when shim is disabled Sep 22, 2023
@danielroe danielroe merged commit a2fb823 into main Sep 22, 2023
33 checks passed
@danielroe danielroe deleted the fix/shim branch September 22, 2023 07:20
This was referenced Sep 22, 2023
Merged
Closed
manniL pushed a commit that referenced this pull request Dec 11, 2023
@danielroe @manniL
fix(nuxt): generate empty file when shim is disabled (#23333)
68b4fe8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danielroe danielroe

Labels
3.x bug 🔨 p3-minor-bug types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unable to remove vue-shim.d.ts
1 participant
@danielroe