New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add explicit await
to clarify sendRedirect
is async
#23345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made the redirect async/await
Run & review this pull request in StackBlitz Codeflow. |
β Live Preview ready!
|
hecktarzuli
changed the title
Update 1.server.md - added async/await to redirect
docs: Updated server redirect example to use async/await
Sep 21, 2023
danielroe
reviewed
Sep 21, 2023
Co-authored-by: Daniel Roe <daniel@roe.dev>
danielroe
changed the title
docs: Updated server redirect example to use async/await
docs: add explicit Sep 22, 2023
await
to clarify that sendRedirect
is async
danielroe
approved these changes
Sep 22, 2023
danielroe
changed the title
docs: add explicit
docs: add explicit Sep 22, 2023
await
to clarify that sendRedirect
is asyncawait
to clarify sendRedirect
is async
Thank you β€οΈ |
Merged
pi0
reviewed
Sep 22, 2023
export default defineEventHandler((event) => { | ||
return sendRedirect(event, '/path/redirect/to', 302) | ||
export default defineEventHandler(async (event) => { | ||
await sendRedirect(event, '/path/redirect/to', 302) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice idea to return + await (only for readability). This way we can chain the result and be upward compatible.
Closed
manniL
pushed a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
made the redirect async/await