New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nuxt): refetch both undefined/null values in useAsyncData
#23351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
warflash
changed the title
fix(nuxt): fix how 'hasCachedData' is determined [#23349]
fix(nuxt): fix how 'hasCachedData' is determined
Sep 22, 2023
4 tasks
8 tasks
danielroe
reviewed
Oct 2, 2023
danielroe
requested changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to add a regression test to cover the situation in the linked issue? π
We can then look at fixing the currently failing tests.
danielroe
approved these changes
Oct 16, 2023
danielroe
changed the title
fix(nuxt): fix how 'hasCachedData' is determined
fix(nuxt): refetch both undefined/null values in Oct 16, 2023
useAsyncData
Merged
manniL
pushed a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves #23349
Resolves #22696
β Type of change
π Description
This ensures nuxt payload data is checked against
null
andundefined
values in the (hopefully) least breaking way possible.When
useNuxtData
is called before a client sideuseAsyncData
call is resolved,useNuxtData
will set the value of the key tonull
.hasCachedData
so far only checked forundefined
values sonull
would pass and be returned, both for theuseAsyncData
anduseNuxtData
.I feel like this is not the cleanest way to go about this, setting they key to undefined like
clearNuxtData
does might be more concise. However then the return signature ofuseNuxtData => <DataT | undefined>
might break existing user logic.π Checklist