Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): rename dts to avoid shadowing w/ baseUrl #23440

Merged
merged 2 commits into from Sep 28, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #23435

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This resolves an issue with setting baseUrl to .nuxt (which probably shouldn't be done anyway), where this would end up shadowing vue-router with .nuxt/vue-router.d.ts.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Sep 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe merged commit 1b34386 into main Sep 28, 2023
33 checks passed
@danielroe danielroe deleted the fix/renamed-stub branch September 28, 2023 07:37
This was referenced Sep 28, 2023
@trandaison
Copy link

Hi @danielroe,
Does this solve this issue? #22752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue Router issue with upgrade of Nuxt 3.6.5 to 3.7.4 (tsconfig baseUrl)
2 participants