Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kit): don't force config.autoImport in addServerImports #23472

Merged
merged 2 commits into from Sep 29, 2023
Merged

fix(kit): don't force config.autoImport in addServerImports #23472

merged 2 commits into from Sep 29, 2023

Conversation

huang-julien
Copy link
Member

🔗 Linked issue

fix #23288

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Hi 👋 this PR removes config.imports.autoImport = true from addServerImports

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Sep 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe changed the title fix(kit): don't enable config.autoImport by addServerImports fix(kit): don't force config.autoImport in addServerImports Sep 29, 2023
@danielroe danielroe merged commit 9734723 into nuxt:main Sep 29, 2023
33 checks passed
@github-actions github-actions bot mentioned this pull request Sep 29, 2023
Merged
manniL pushed a commit that referenced this pull request Dec 11, 2023
@huang-julien @manniL
fix(kit): don't force config.autoImport in addServerImports (#23472)
13a6d99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

@pi0 pi0 Awaiting requested review from pi0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huang-julien @danielroe