fix(nuxt): ignore prefix if clearNuxtState called w/o keys
#23483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danielroe
reviewed
Oct 1, 2023
Comment on lines
44
to
+45
| const _allKeys = Object.keys(nuxtApp.payload.state) | ||
| .map(key => key.substring(useStateKeyPrefix.length)) |
There was a problem hiding this comment.
I would also welcome a future PR that improves perf by not enumerating state keys when an array of strings is provided as the keys arg.
danielroe
changed the title
clearNuxtState called w/o keys
Merged
manniL
pushed a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #23482.
❓ Type of change
📚 Description
This fixes
clearNuxtStatebehavior when called with a function or with no arguments. Internally,useStateprefixes all keys. WhenclearNuxtStateis called with a callback, it should not be needed to provide the prefix on keys from the calling side (this is an implementation detail). Also, when called without argument, all keys should be reset. The current behavior resets none, because all prefixed keys are prefixed again and then removed (which matches none).I added mulitple tests as a separate
describeto make sure all functionality is tested.📝 Checklist