fix(nuxt): use test/dev as manifest buildId when appropriate
#23512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pi0
approved these changes
Oct 3, 2023
pi0
reviewed
Oct 3, 2023
packages/nuxt/src/core/nitro.ts
Outdated
| @@ -213,7 +213,7 @@ export async function initNitro (nuxt: Nuxt & { _nitro?: Nitro }) { | |||
| // Add app manifest handler and prerender configuration | |||
| if (nuxt.options.experimental.appManifest) { | |||
| // @ts-expect-error untyped nuxt property | |||
| const buildId = nuxt.options.appConfig.nuxt!.buildId ||= randomUUID() | |||
| const buildId = nuxt.options.appConfig.nuxt!.buildId ||= (nuxt.options.test ? 'test' : randomUUID()) | |||
There was a problem hiding this comment.
Haven't checked impl but is dev also considered?
There was a problem hiding this comment.
Do you mean in dev (non-test) we should default to dev or something similar?
There was a problem hiding this comment.
Yes (either this field is optional or if we can serve it dev, i think a predictable value could be nice).
danielroe
changed the title
test as manifest buildId when testingtest/dev as manifest buildId when appropriate
Merged
manniL
pushed a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
With new app manifest enabled, we can potentially have a source of unreliable test data in that we have a constantly changing buildId which is difficult to mock (see danielroe/nuxt-vitest#354).
This PR defaults the buildId (unless user overrides) to
testwhen running in e2e/unit test environments.📝 Checklist