Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix various typos and update to US English #23580

Merged
merged 2 commits into from Oct 10, 2023

Conversation

adeyinkaezra123
Copy link
Contributor

πŸ”— Linked issue

No linked issue(s)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)

πŸ“š Description

Rectified typos and spelling mistakes.

@stackblitz
Copy link

stackblitz bot commented Oct 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nuxt-studio
Copy link

nuxt-studio bot commented Oct 8, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio β†—οΈŽ View Live Preview b8fe8a1

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❀️

Comment on lines +1899 to +1900
const [key, serializedComponent] = entries.find(([key]) => key.startsWith('AsyncServerComponent')) || []
expect(serializedComponent).toEqual(key)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general we can use UK English in tests and in code; these aren't spelling mistakes in this context...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, okay πŸ‘

test/fixtures/basic/extends/bar/middleware/override.ts Outdated Show resolved Hide resolved
docs/1.getting-started/12.upgrade.md Outdated Show resolved Hide resolved
docs/2.guide/2.directory-structure/1.components.md Outdated Show resolved Hide resolved
@danielroe danielroe changed the title chore: fix typos in files across repo chore: fix various typos and update to US English Oct 10, 2023
@danielroe danielroe merged commit 8db82af into nuxt:main Oct 10, 2023
34 of 35 checks passed
@github-actions github-actions bot mentioned this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants