Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): ensure we add prerender hints to correct event #23799

Merged
merged 4 commits into from Oct 19, 2023
Merged

fix(nuxt): ensure we add prerender hints to correct event #23799

merged 4 commits into from Oct 19, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Introduced in #22863, we were not passing context when hinting to prerender island routes.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Oct 19, 2023
@stackblitz
Copy link

stackblitz bot commented Oct 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe changed the title fix(nuxt): call prerenderRoutes with nuxt context fix(nuxt): ensure we use correct event when adding prerender hints Oct 19, 2023
@danielroe danielroe changed the title fix(nuxt): ensure we use correct event when adding prerender hints fix(nuxt): ensure we add prerender hints to correct event Oct 19, 2023
@danielroe danielroe merged commit 8c9333a into main Oct 19, 2023
34 checks passed
@danielroe danielroe deleted the fix/granular-hint branch October 19, 2023 22:44
@github-actions github-actions bot mentioned this pull request Oct 19, 2023
Merged
manniL pushed a commit that referenced this pull request Dec 11, 2023
@danielroe @manniL
fix(nuxt): ensure we add prerender hints to correct event (#23799)
bf05a1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huang-julien huang-julien huang-julien approved these changes

Assignees

@danielroe danielroe

Labels
3.x bug 🔨 p3-minor-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @huang-julien