Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt,schema): use std-env to detect whether app is being tested #23830

Merged
merged 2 commits into from Oct 20, 2023
Merged

fix(nuxt,schema): use std-env to detect whether app is being tested #23830

merged 2 commits into from Oct 20, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #23829

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

As nuxt.options.test defaults to true in dev mode this updates buildId to test for it first.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Oct 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe requested a review from pi0 October 20, 2023 15:18
@danielroe danielroe changed the title fix(nuxt): set buildId to dev in dev mode fix(nuxt,schema): use std-env to detect whether app is being tested Oct 20, 2023
@danielroe danielroe marked this pull request as ready for review October 20, 2023 15:29
@danielroe danielroe merged commit 591f430 into main Oct 20, 2023
34 checks passed
@danielroe danielroe deleted the fix/dev-build-id branch October 20, 2023 15:52
@github-actions github-actions bot mentioned this pull request Oct 20, 2023
Merged
manniL pushed a commit that referenced this pull request Dec 11, 2023
@danielroe @manniL
fix(nuxt,schema): use std-env to detect whether app is being tested (…
995b3ca 
…#23830)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manniL manniL manniL approved these changes

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App manifest: Name is test.json in dev
3 participants
@danielroe @manniL @pi0