Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(nuxt): use useRequestEvent() internally #23916

Merged
merged 1 commit into from Oct 25, 2023
Merged

refactor(nuxt): use useRequestEvent() internally #23916

merged 1 commit into from Oct 25, 2023

Conversation

bastienrossi
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Reading the code to see the structure of an ssr request, I noticed a duplication of logic.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Oct 24, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

danielroe
danielroe approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@danielroe danielroe changed the title refactor(nuxt): use requestEvent function instead of duplicate logic refactor(nuxt): use useRequestEvent() internally Oct 25, 2023
@danielroe danielroe merged commit e4e3889 into nuxt:main Oct 25, 2023
33 checks passed
@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Merged
manniL pushed a commit that referenced this pull request Dec 11, 2023
@bastienrossi @manniL
refactor(nuxt): use useRequestEvent() internally (#23916)
0960a5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bastienrossi @danielroe