Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): resolve imports from virtual files #24022

Merged
merged 5 commits into from Nov 1, 2023
Merged

fix(nuxt): resolve imports from virtual files #24022

merged 5 commits into from Nov 1, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Discovered while reproducing an issue, we need to fully resolve all imports in templates: #14146.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Oct 30, 2023
@stackblitz
Copy link

stackblitz bot commented Oct 30, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

pi0
pi0 reviewed Oct 30, 2023
View reviewed changes
test/bundle.test.ts Outdated Show resolved Hide resolved
@danielroe danielroe changed the title fix(nuxt): resolve ofetch for unhoisted use fix(nuxt): resolve imports from virtual files Oct 31, 2023
@danielroe danielroe merged commit e753abd into main Nov 1, 2023
34 checks passed
@danielroe danielroe deleted the fix/resolve-ofetch branch November 1, 2023 15:55
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Merged
manniL pushed a commit that referenced this pull request Dec 11, 2023
@danielroe @manniL
fix(nuxt): resolve imports from virtual files (#24022)
09e81bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 left review comments

Assignees

@danielroe danielroe

Labels
3.x bug 🔨 p3-minor-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @pi0