Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove unused import from example #24168

Merged
merged 1 commit into from Nov 7, 2023
Merged

docs: remove unused import from example #24168

merged 1 commit into from Nov 7, 2023

Conversation

bmulholland
Copy link
Contributor

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

@stackblitz StackBlitz
Copy link

stackblitz bot commented Nov 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nuxt-studio Nuxt Studio
Copy link

nuxt-studio bot commented Nov 7, 2023

✅ Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio ↗︎ View Live Preview 718f0d5

@bmulholland
Copy link
Contributor Author

Why is docs not a valid sematic commit?

@danielroe danielroe changed the title chore(docs): Remove unused import from example docs: remove unused import from example Nov 7, 2023
@danielroe danielroe merged commit bebab7f into nuxt:main Nov 7, 2023
4 of 5 checks passed
@github-actions github-actions bot mentioned this pull request Nov 7, 2023
Merged
@danielroe
Copy link
Member

it's because we have a defined list of valid scopes:

nuxt/.github/workflows/semantic-pull-requests.yml

Lines 25 to 33 in 9ef94d6

scopes: |
kit
nuxi
nuxt
schema
test-utils
vite
webpack
deps

@bmulholland
Copy link
Contributor Author

Ohh it's because docs is the type, not the scope. Thanks for fixing!

@bmulholland bmulholland deleted the patch-1 branch November 7, 2023 15:01
manniL pushed a commit that referenced this pull request Dec 11, 2023
@manniL
docs: remove unused import from example (#24168)
6c26726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bmulholland @danielroe