Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove deprecated loadNuxt options #24201

Merged
merged 5 commits into from Dec 14, 2023
Merged

Conversation

MichaelJCole
Copy link
Contributor

@MichaelJCole MichaelJCole commented Nov 8, 2023

πŸ”— Linked issue

#24197

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Update loadNuxt documentation to latest version. config option was removed. cwd option is standard.
The docs are out of date for these options. I filed a bug, then found the fix. This updates the docs for the next guy.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Update loadNuxt documentation to latest version.  `config` option was removed.  `cwd` option is standard.
Copy link

stackblitz bot commented Nov 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

nuxt-studio bot commented Nov 8, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio β†—οΈŽ View Live Preview 1e17ff6

docs/3.api/5.kit/2.programmatic.md Outdated Show resolved Hide resolved
docs/3.api/5.kit/2.programmatic.md Outdated Show resolved Hide resolved
docs/3.api/5.kit/2.programmatic.md Outdated Show resolved Hide resolved
@DamianGlowala DamianGlowala changed the title Update 2.programmatic.md docs: update loadNuxt() params Nov 11, 2023
@DamianGlowala DamianGlowala changed the title docs: update loadNuxt() params docs: update loadNuxt params Nov 11, 2023
@@ -53,24 +53,20 @@ Loading conditions for Nuxt. `loadNuxt` uses [`c12`](https://github.com/unjs/c12

If set to `true`, Nuxt will be ready to use after the `loadNuxt` call. If set to `false`, you will need to call `nuxt.ready()` to make sure Nuxt is ready to use.

- `rootDir` (optional)
- `cwd` (optional)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two parameters are both documented in the link above (https://github.com/unjs/c12).

This is meant to be a list of additional options that are respected.

Instead, shall we just remove them?

@danielroe danielroe changed the title docs: update loadNuxt params docs: remove deprecated loadNuxt options Dec 14, 2023
@danielroe danielroe merged commit 0c04dc0 into nuxt:main Dec 14, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants