docs: update code to show how to enable typedPages
#24436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Live Preview ready!
|
maninak
changed the title
typedPages: falsetypedPages: false
maninak
force-pushed
the
docs/typedpages-suggest-true
branch
from
09cdb80
to
14b4b90
Compare
danielroe
approved these changes
Nov 23, 2023
|
Thanks! Nice catch. |
danielroe
changed the title
typedPages: falsetypedPages
Closed
Merged
manniL
pushed a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
There is no related issue for this PR, to my knowledge.
❓ Type of change
📚 Description
At the "Experimental Features" page of the docs, in the "typedPages" section, while the description implies that the code that follows will enable the feature, it actually disables it.
Source: https://nuxt.com/docs/guide/going-further/experimental-features#typedpages
Screenshot:
In fact this fooled me enough to actually erroneously copy it from the docs as is! 🤦♂️
Thankfully my colleague caught it in the PR review.
This PR fixes the example to correctly suggest setting the value
truefor the propertytypedPagesunderexperimentalinnuxt.config.js.📝 Checklist