New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: label pull requests based on their target branch #24468
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #24468 +/- ##
=======================================
Coverage ? 58.65%
=======================================
Files ? 5
Lines ? 861
Branches ? 46
=======================================
Hits ? 505
Misses ? 356
Partials ? 0 β View full report in Codecov by Sentry. |
Looks like the |
This is a great idea. β€οΈ It might be that the token on your fork doesn't have permissions to add labels on the main branch, or otherwise anyone could end up doing nefarious things. I would suggest instead using the nuxt/.github/workflows/semantic-pull-requests.yml Lines 3 to 8 in 9ef94d6
This will also run 'from' the main branch so shouldn't have any permission issues. |
Oh silly me, I haven't realized the token being used is from my fork π I've updated the trigger as you suggested, thank you for the feedback!^^ This means though that the workflow won't run for this PR, but I've tested the exact same code in one of my own repositories to make sure it works. |
π Linked issue
β Type of change
π Description
I've seen Daniel adding the
2.x
and3.x
labels manually to PRs and wanted to help him out by labelling my own PR. Unfortunately, contributors don't have permission to edit PR labels, so I couldn't do that.This PR makes this process automated.
π Checklist