New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nuxt): island components with number prefix #24469
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Not really sure what's going on with these failed tests, any ideas? Seems like a isolation / cache issue |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #24469 +/- ##
=======================================
Coverage ? 58.65%
=======================================
Files ? 5
Lines ? 861
Branches ? 46
=======================================
Hits ? 505
Misses ? 356
Partials ? 0 β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works locally π , ok for me
Oh right! thanks @danielroe πββοΈ |
π Linked issue
https://stackblitz.com/edit/nuxt-starter-xchkk1?file=app.vue
β Type of change
π Description
Using an island component that starts with a number completely breaks the island renderer, this is because it will introduce a syntax error within the template used to load the component.
To fix this I've just copied the convention used for the global components template.
π Checklist