Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): remove trailing slash before checking if prerendered #24516

Merged
merged 1 commit into from Nov 29, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Nov 28, 2023

πŸ”— Linked issue

resolves #24456
resolves #24392

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

As rightly pointed out by @Adamkillander96 in #24456 (comment), we strip trailing slashes when creating the app manifest, and it makes sense to remove these when checking if a route has been prerendered (for fetching payloads, etc.)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Nov 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

❗ No coverage uploaded for pull request base (main@09161d0). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #24516   +/-   ##
=======================================
  Coverage        ?   58.65%           
=======================================
  Files           ?        5           
  Lines           ?      861           
  Branches        ?       46           
=======================================
  Hits            ?      505           
  Misses          ?      356           
  Partials        ?        0           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe danielroe changed the title fix(nuxt): remove trailing slash before checking if i prerendered fix(nuxt): remove trailing slash before checking if prerendered Nov 29, 2023
@danielroe danielroe merged commit 5b4d638 into main Nov 29, 2023
36 checks passed
@danielroe danielroe deleted the fix/prerendered-trailing-slash branch November 29, 2023 10:18
@github-actions github-actions bot mentioned this pull request Nov 29, 2023
@lassediercks
Copy link

thank you for approaching this πŸ₯³

@Adamkillander96
Copy link

Wow, that was fast! 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants