Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite,webpack): don't add type checker/analyzer when testing #24608

Merged
merged 2 commits into from Dec 5, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/test-utils#295

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This avoids instantiating the type checker and build analysis plugins when running unit/e2e tests on Nuxt.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Dec 5, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the 3.x label Dec 5, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

❗ No coverage uploaded for pull request base (main@6a1c054). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #24608   +/-   ##
=======================================
  Coverage        ?   58.65%           
=======================================
  Files           ?        5           
  Lines           ?      861           
  Branches        ?       46           
=======================================
  Hits            ?      505           
  Misses          ?      356           
  Partials        ?        0           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe danielroe requested a review from manniL December 5, 2023 15:52
@danielroe danielroe changed the title fix(vite,webpack): disallow adding type checker and analyze plugins when testing app fix(vite,webpack): don't add type checker/analyzer when testing Dec 5, 2023
@danielroe danielroe merged commit 1e393ad into main Dec 5, 2023
34 checks passed
@danielroe danielroe deleted the fix/typecheck-test branch December 5, 2023 17:09
@github-actions github-actions bot mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vitest crash when typecheck set to true
3 participants