Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: warn about using different env variables for runtimeConfig #24612

Merged
merged 5 commits into from Dec 5, 2023

Conversation

manniL
Copy link
Member

@manniL manniL commented Dec 5, 2023

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I've seen the pattern a few times, causing issues during runtime.

export default defineNuxtConfig({
  runtimeConfig: {
    apiSecret: process.env.SOME_OTHER_VALUE, // This will break when trying to set SOME_OTHER_VALUE during runtime
    apiKey: process.env.API_KEY.trim(), // This won't transform values when setting API_KEY during runtime
  },
})

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@manniL manniL requested a review from danielroe December 5, 2023 16:47
Copy link

stackblitz bot commented Dec 5, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

nuxt-studio bot commented Dec 5, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio β†—οΈŽ View Live Preview f8c3dc5

@github-actions github-actions bot added the 3.x label Dec 5, 2023
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘Œ

@danielroe danielroe merged commit 64146b4 into main Dec 5, 2023
4 checks passed
@danielroe danielroe deleted the manniL-patch-1 branch December 5, 2023 17:47
@github-actions github-actions bot mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants