Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): merge and apply layer hooks #24639

Merged
merged 4 commits into from Dec 8, 2023
Merged

fix(nuxt): merge and apply layer hooks #24639

merged 4 commits into from Dec 8, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

#13367

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Rather than relying on c12 to merge hooks, this simply iterates over layers to ensure all layer hooks are merged/respected in the final hookable instance.

We reverse the layer order to ensure that final user hooks run last, with layer hooks being added first.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Dec 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe mentioned this pull request Dec 7, 2023
18 tasks
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

❗ No coverage uploaded for pull request base (main@88498be). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #24639   +/-   ##
=======================================
  Coverage        ?   58.65%           
=======================================
  Files           ?        5           
  Lines           ?      861           
  Branches        ?       46           
=======================================
  Hits            ?      505           
  Misses          ?      356           
  Partials        ?        0           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe danielroe merged commit 0c83246 into main Dec 8, 2023
33 checks passed
@danielroe danielroe deleted the fix/merge-hooks branch December 8, 2023 12:51
@github-actions github-actions bot mentioned this pull request Dec 8, 2023
manniL pushed a commit that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants