Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): allow modules to disable appManifest without crashing #24786

Merged
merged 9 commits into from Dec 16, 2023
Merged

fix(nuxt): allow modules to disable appManifest without crashing #24786

Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b081b81
fix(nuxt): allow modules to disable `appManifest` without crashing
IonianPlayboy Dec 15, 2023
ce326f5
Update packages/nuxt/src/core/nuxt.ts
danielroe Dec 16, 2023
a186beb
Update packages/nuxt/src/core/nuxt.ts
danielroe Dec 16, 2023
0690768
Update packages/nuxt/src/core/nuxt.ts
danielroe Dec 16, 2023
ab387c3
Update packages/nuxt/src/core/nuxt.ts
danielroe Dec 16, 2023
d7ee29a
Update packages/nuxt/src/core/nuxt.ts
danielroe Dec 16, 2023
7be26e7
Update packages/nuxt/src/core/nuxt.ts
danielroe Dec 16, 2023
e8d4e55
Update packages/nuxt/src/core/nuxt.ts
danielroe Dec 16, 2023
ff54441
Update packages/nuxt/src/core/nuxt.ts
danielroe Dec 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 9 additions & 10 deletions packages/nuxt/src/core/nuxt.ts
View file
Open in desktop
Expand Up @@ -94,16 +94,6 @@ async function initNuxt (nuxt: Nuxt) {
addVitePlugin(() => ImportProtectionPlugin.vite(config))
addWebpackPlugin(() => ImportProtectionPlugin.webpack(config))

if (nuxt.options.experimental.appManifest) {
addRouteMiddleware({
name: 'manifest-route-rule',
path: resolve(nuxt.options.appDir, 'middleware/manifest-route-rule'),
global: true
})

addPlugin(resolve(nuxt.options.appDir, 'plugins/check-outdated-build.client'))
}

// add resolver for modules used in virtual files
addVitePlugin(() => resolveDeepImportsPlugin(nuxt))

Expand Down Expand Up @@ -400,6 +390,15 @@ async function initNuxt (nuxt: Nuxt) {
}

danielroe marked this conversation as resolved.
Show resolved Hide resolved
await nuxt.callHook('modules:done')
if (nuxt.options.experimental.appManifest) {
danielroe marked this conversation as resolved.
Show resolved Hide resolved
addRouteMiddleware({
name: 'manifest-route-rule',
path: resolve(nuxt.options.appDir, 'middleware/manifest-route-rule'),
global: true
})

addPlugin(resolve(nuxt.options.appDir, 'plugins/check-outdated-build.client'))
}

danielroe marked this conversation as resolved.
Show resolved Hide resolved
nuxt.hooks.hook('builder:watch', (event, relativePath) => {
const path = resolve(nuxt.options.srcDir, relativePath)
Expand Down