Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(vite): avoid duplicate JSON.stringify operation #24848

Merged
merged 1 commit into from Dec 21, 2023

Conversation

GalacticHypernova
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Save the stringified json to avoid a re-stringification.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Dec 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the 3.x label Dec 20, 2023
Copy link

codspeed-hq bot commented Dec 20, 2023

CodSpeed Performance Report

Merging #24848 will improve performances by Γ—2.4

Comparing GalacticHypernova:patch-11 (e2a2919) with main (ba0d274)

Summary

⚑ 3 improvements
βœ… 5 untouched benchmarks

Benchmarks breakdown

Benchmark main GalacticHypernova:patch-11 Change
⚑ minimal test fixture (types) 57 ms 42.5 ms +34.13%
⚑ minimal test fixture 136 ms 57.5 ms Γ—2.4
⚑ basic test fixture (types) 607.3 ms 349 ms +74.02%

@danielroe danielroe merged commit 59cac48 into nuxt:main Dec 21, 2023
37 checks passed
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants