Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit,nuxt,vite,webpack): add toArray util #24857

Merged
merged 12 commits into from Dec 23, 2023
Merged

Conversation

DamianGlowala
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds a generic toArray util to replace repeatable ternary Array.isArray() checks.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Dec 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@DamianGlowala DamianGlowala changed the title feat(kit,nuxt,webpack): add toArray util feat(kit,nuxt,vite,webpack): add toArray util Dec 21, 2023
Copy link

codspeed-hq bot commented Dec 21, 2023

CodSpeed Performance Report

Merging #24857 will improve performances by Γ—2.2

Comparing feat/to-array-util (3e35b19) with main (1a9fb57)

Summary

⚑ 1 improvements
βœ… 7 untouched benchmarks

Benchmarks breakdown

Benchmark main feat/to-array-util Change
⚑ minimal test fixture (types) 136.3 ms 61.4 ms Γ—2.2

@danielroe danielroe merged commit a2ef309 into main Dec 23, 2023
36 of 38 checks passed
@danielroe danielroe deleted the feat/to-array-util branch December 23, 2023 14:22
This was referenced Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants