Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(nuxt): ensure renderHTMLDocument return more compact result #24888

Merged
merged 9 commits into from Jan 4, 2024
Merged

perf(nuxt): ensure renderHTMLDocument return more compact result #24888

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4537e0a
chore: ensure `renderHTMLDocument` return more compact result
Mini-ghost Dec 25, 2023
4d94ed9
perf(nuxt): avoid empty string arrays
Mini-ghost Dec 25, 2023
2cf913e
perf(nuxt): use string concatenation instead of `Array.prototype.join()`
Mini-ghost Dec 25, 2023
6e879da
chore(nuxt): remove unnecessary `trim()`
Mini-ghost Dec 25, 2023
398f0e5
Merge branch 'main' into chore/reduce-document-size
Mini-ghost Dec 26, 2023
32d703c
Merge branch 'main' into chore/reduce-document-size
Mini-ghost Dec 30, 2023
754817f
fix: ensure no extra white space
Mini-ghost Jan 4, 2024
7f0030b
Merge branch 'main' into chore/reduce-document-size
Mini-ghost Jan 4, 2024
2d85caf
refactor: simplify code
Mini-ghost Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/nuxt/src/core/runtime/nitro/renderer.ts
View file
Open in desktop
Expand Up @@ -412,9 +412,9 @@ export default defineRenderHandler(async (event): Promise<Partial<RenderResponse
// Create render context
const htmlContext: NuxtRenderHTMLContext = {
island: Boolean(islandContext),
htmlAttrs: [htmlAttrs],
htmlAttrs: htmlAttrs ? [htmlAttrs] : [],
head: normalizeChunks([headTags, ssrContext.styles]),
bodyAttrs: [bodyAttrs],
bodyAttrs: bodyAttrs ? [bodyAttrs] : [],
bodyPrepend: normalizeChunks([bodyTagsOpen, ssrContext.teleports?.body]),
body: [process.env.NUXT_COMPONENT_ISLANDS ? replaceClientTeleport(ssrContext, replaceServerOnlyComponentsSlots(ssrContext, _rendered.html)) : _rendered.html],
bodyAppend: [bodyTags]
Expand Down Expand Up @@ -502,11 +502,11 @@ function joinAttrs (chunks: string[]) {
}

function renderHTMLDocument (html: NuxtRenderHTMLContext) {
return `<!DOCTYPE html>
<html ${joinAttrs(html.htmlAttrs)}>
<head>${joinTags(html.head)}</head>
<body ${joinAttrs(html.bodyAttrs)}>${joinTags(html.bodyPrepend)}${joinTags(html.body)}${joinTags(html.bodyAppend)}</body>
</html>`
return '<!DOCTYPE html>'
+ `<html${joinAttrs(html.htmlAttrs)}>`
+ `<head>${joinTags(html.head)}</head>`
+ `<body${joinAttrs(html.bodyAttrs)}>${joinTags(html.bodyPrepend)}${joinTags(html.body)}${joinTags(html.bodyAppend)}</body>`
+ '</html>'
}

async function renderInlineStyles (usedModules: Set<string> | string[]): Promise<Style[]> {
Expand Down