Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): catch error in NuxtErrorBoundary if not server rendered #24896

Merged
merged 1 commit into from Dec 25, 2023
Merged

fix(nuxt): catch error in NuxtErrorBoundary if not server rendered #24896

merged 1 commit into from Dec 25, 2023

Conversation

huang-julien
Copy link
Member

@huang-julien huang-julien commented Dec 25, 2023 •
edited

🔗 Linked issue

fix #24889

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Hi 👋 just a small fix to make NuxtErrorBoundary catch the error if the app isn't server rendered

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Dec 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the 3.x label Dec 25, 2023
@danielroe danielroe merged commit 8ba118f into main Dec 25, 2023
37 checks passed
@danielroe danielroe deleted the fix/error-boubndary-nossr branch December 25, 2023 17:54
@github-actions github-actions bot mentioned this pull request Dec 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NuxtErrorBoundary does not work properly when ssr is set to false
2 participants
@huang-julien @danielroe