Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): don't show transition on initial page load #24935

Merged
merged 4 commits into from Jan 2, 2024

Conversation

bernhardberger
Copy link
Contributor

@bernhardberger bernhardberger commented Dec 28, 2023

check if from route is START_LOCATION from vue-router in isChangingPage to detect first page load (like page refresh or first hit). When there is no previous route then there is no changing page. This causes pages to not scroll down to the hash on pages that are not on the / route.

πŸ”— Linked issue

#24934

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add check if from route is START_LOCATION vom vue-router in isChangingPage utility. Without this check it returns a false positive on page refresh or initial load.
Resolves #24934

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Dec 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the 3.x label Dec 28, 2023
check if `from` route is `START_LOCATION` from vue-router in isChangingPage to detect first page load (like page refresh or first hit). When there is no previous route then there sould be no changing page.
@danielroe danielroe changed the title fix: detect first page load in isChangingPage fix(nuxt): don't show transition on initial page load Jan 2, 2024
@danielroe danielroe merged commit 1602080 into nuxt:main Jan 2, 2024
35 checks passed
@github-actions github-actions bot mentioned this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants