Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): clone cookie to detect changes within object #25007

Merged
merged 2 commits into from Jan 2, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #24969

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When a cookie is an object, changing a property within it will change the original referenced object as well, meaning isEqual doesn't detect the change. Instead, we can clone the value straight away so we can detect differences.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Jan 2, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the 3.x label Jan 2, 2024
Copy link
Member

@manniL manniL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole stream approves πŸ˜›

@danielroe danielroe merged commit 7087a06 into main Jan 2, 2024
35 checks passed
@danielroe danielroe deleted the fix/clone-cookie branch January 2, 2024 15:37
This was referenced Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useCookie doesn't change value of an object stored in cookie
2 participants