Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: suggest using <NuxtPage> rather than <RouterView> #25106

Merged
merged 2 commits into from Jan 9, 2024
Merged

docs: suggest using <NuxtPage> rather than <RouterView> #25106

merged 2 commits into from Jan 9, 2024

Conversation

toto6038
Copy link
Contributor

@toto6038 toto6038 commented Jan 8, 2024

🔗 Linked issue

#25089

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Describe the problem mentioned in #25089.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

cc @manniL

@stackblitz StackBlitz
Copy link

stackblitz bot commented Jan 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nuxt-studio Nuxt Studio
Copy link

nuxt-studio bot commented Jan 8, 2024

✅ Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio ↗︎ View Live Preview 7afee4b

@github-actions github-actions bot added the 3.x label Jan 8, 2024
@toto6038 toto6038 changed the title docs: describe the problem of using <RouterView> rather than `<Nuxt… docs: describe the problem of using <RouterView> rather than <NuxtPage> Jan 8, 2024
@toto6038
Copy link
Contributor Author

toto6038 commented Jan 9, 2024

I would like to point out that the live preview generated by nuxt-studio bot seems to not reflect the changes in the PR.

@manniL manniL changed the title docs: describe the problem of using <RouterView> rather than <NuxtPage> docs: suggest using <RouterView> rather than <NuxtPage> Jan 9, 2024
@manniL manniL merged commit e07932b into nuxt:main Jan 9, 2024
3 of 4 checks passed
@manniL manniL changed the title docs: suggest using <RouterView> rather than <NuxtPage> docs: suggest using <NuxtPage> rather than <RouterView> Jan 9, 2024
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
Merged
danielroe pushed a commit that referenced this pull request Jan 9, 2024
@toto6038 @danielroe
docs: suggest using <NuxtPage> rather than <RouterView> (#25106)
f78140e
danielroe pushed a commit that referenced this pull request Jan 9, 2024
@toto6038
docs: suggest using <NuxtPage> rather than <RouterView> (#25106)
4168157
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Closed
@NozomuIkuta NozomuIkuta mentioned this pull request Jan 29, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manniL manniL manniL approved these changes

Assignees
No one assigned
Labels
3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@toto6038 @manniL