chore(kit): improve types for addTemplate #25109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danielroe
reviewed
Jan 10, 2024
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
|
Co-authored-by: Daniel Roe <daniel@roe.dev>
|
This failure looks like an issue in nuxt/content - nicely discovered through this PR. 🙌 |
danielroe
approved these changes
Jan 10, 2024
|
Oh - one comment. IIRC, we changed the type signature in Nuxt 3 vs Nuxt 2. We should confirm that this type is accurate for Nuxt 2 projects as well 🤔 |
brawaru
added a commit
to brawaru/nuxt
that referenced
this pull request
Jan 31, 2024
nuxt/nuxt#25109 introduced options types to addTemplate, which caused TypeScript to explode because it's a bit stoopid (big mood) and cannot infer a generic type that's referenced within the initialisation of that type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Providing better type definition with the
optionsproperty along with the right definition forgetContentsparameter, and cleaned up redundant code where we were typing the context.📝 Checklist