Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): add script block if there's none before island transformation #25148

Merged
merged 3 commits into from Jan 11, 2024

Conversation

huang-julien
Copy link
Member

πŸ”— Linked issue

fix #25147

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Hi πŸ‘‹
This PR fix #25147 because in the example, there's no <script> block so the SFC will be missing imports when transformed by islandTransform plugin

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Jan 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the 3.x label Jan 10, 2024
Co-authored-by: Daniel Roe <daniel@roe.dev>
@danielroe danielroe merged commit 2280070 into main Jan 11, 2024
34 checks passed
@danielroe danielroe deleted the fix/nsc_island_transfo_missingsciprt branch January 11, 2024 14:40
This was referenced Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using nuxt-client throws Fail to resolve component: NuxtTeleportSsrClient
2 participants