fix(nuxt): check for uid before replacing data-island-uid attribute in island #25245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
danielroe/roe.dev@b33100c
β Type of change
π Description
Hi π this PR fix an issue where nested islands can be buggy and render invalid html (double attributes).
This is due to the fact that we were replacing all data-island-uid without checking if those were already set.
I'll add a test later.
π Checklist