Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): check for uid before replacing data-island-uid attribute in island #25245

Merged
merged 2 commits into from Jan 17, 2024

Conversation

huang-julien
Copy link
Member

πŸ”— Linked issue

danielroe/roe.dev@b33100c

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Hi πŸ‘‹ this PR fix an issue where nested islands can be buggy and render invalid html (double attributes).

This is due to the fact that we were replacing all data-island-uid without checking if those were already set.

I'll add a test later.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@huang-julien huang-julien self-assigned this Jan 17, 2024
Copy link

stackblitz bot commented Jan 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the 3.x label Jan 17, 2024
@huang-julien huang-julien changed the title fix(nuxt): avoid replacing all data-island-uid within an island fix(nuxt): check for uid before replacing data-island-uid attribute in island Jan 17, 2024
Co-authored-by: Daniel Roe <daniel@roe.dev>
@danielroe danielroe merged commit d15f0c4 into main Jan 17, 2024
34 checks passed
@danielroe danielroe deleted the fix/nesteduid branch January 17, 2024 10:48
@github-actions github-actions bot mentioned this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants