Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): make slot response fallback property undefineable #25296

Merged
merged 4 commits into from Jan 18, 2024

Conversation

huang-julien
Copy link
Member

@huang-julien huang-julien commented Jan 18, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Hey πŸ‘‹ this PR makes the fallback field for slots in the NuxtIslandResponse undefined by default.

Before that, there was a nullish operator which was triggering esbuild warning when building (in dev).

I think it's better to move the nullish operator to an OR (||) and make the field undefineable instead

PS: is there a way to detect that in the CI ?

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Jan 18, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the 3.x label Jan 18, 2024
@huang-julien huang-julien marked this pull request as draft January 18, 2024 18:12
@huang-julien huang-julien marked this pull request as ready for review January 18, 2024 20:39
@danielroe danielroe merged commit ce7845c into main Jan 18, 2024
34 checks passed
@danielroe danielroe deleted the fix/esbuild_warn branch January 18, 2024 22:20
@github-actions github-actions bot mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants