Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove miswritten test #25347

Merged
merged 1 commit into from Jan 21, 2024
Merged

test: remove miswritten test #25347

merged 1 commit into from Jan 21, 2024

Conversation

huang-julien
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Hello πŸ‘‹ this Pr removes a test that was not working since playwright isn't able to properly detect the loading indicator without a waitForTimeout of 400ms.

The test has also an issue that the selector is wrong so playwright is supposed to never be able to find the loading indicator meaning this test will always be successfull (even if theres a bug).

Would welcome any suggestion to make it testable.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Jan 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the 3.x label Jan 20, 2024
@huang-julien huang-julien changed the title test: remove not working test test: remove miswritten test Jan 20, 2024
@danielroe danielroe merged commit 89541f4 into main Jan 21, 2024
36 checks passed
@danielroe danielroe deleted the test/remove-not-working-test branch January 21, 2024 11:31
@github-actions github-actions bot mentioned this pull request Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants