fix(nuxt): set useFetch accept default to application/json
#25390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pi0
reviewed
Jan 29, 2024
|
|
||
| // Use fetch with request context and headers for server direct API calls | ||
| if (import.meta.server && !opts.$fetch) { | ||
| const isLocalFetch = typeof _request.value === 'string' && _request.value[0] === '/' && (!toValue(opts.baseURL) || toValue(opts.baseURL)![0] === '/') | ||
| if (isLocalFetch) { | ||
| _$fetch = useRequestFetch() | ||
| // Set default `accept` value to avoid it defaulting to `text/html` (from initial browser request) | ||
| headers.accept = 'application/json' |
There was a problem hiding this comment.
Maybe instead avoid to proxy accept header? (I guess bits are in h3 for proxy, but don't remember code we might also have list still in Nuxt for default headers to ignore)
This seems a bug that we proxy browser's accept header down to API calls. ofetch defaults to the right accept header based on body but if we explicitly ovveride here, it cannot do this anymore.
There was a problem hiding this comment.
Okay, let's fix it upstream then 👍
|
closing ~> unjs/h3#646 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #24742
resolves #24609
resolves #23539
❓ Type of change
📚 Description
When using
useFetch, we automatically use the request event fetch, which preserves headers from the initial request. Unfortunately, this also proxies theacceptheader, which istext/htmlfrom the browser, and can result in all local fetches withuseFetchreturning HTML error messages rather than JSON.This PR also normalises the headers object (which was not previously working with nested refs).
📝 Checklist